Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Adding document and notebooks for ONNXModel #1164
docs: Adding document and notebooks for ONNXModel #1164
Changes from all commits
bccb19c
3f1ef73
9c6efd0
671aaf4
2410a50
602cdd9
fd26216
4a673f7
88ea2e0
cb3a4c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share a little details on why this stuff is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method
writeNestedSeqToStringBuffer
, together withwriteNestedSeqToBuffer
, are used to replace theflattenNested
method.flattenNested
flattens a nested Seq to a 1-d array, but is super slow due to repeated memory allocation.writeNestedSeqToStringBuffer
andwriteNestedSeqToBuffer
both allocates the memory buffer one time, and write the nestedSeq
to the buffer. I did some local testing, and they appear to be 5-10 times faster thanflattenNested
.The reason I need two methods is because there is not a nio.Buffer class for string type, so I had to replace it with a ArrayBuffer[String].