Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve LightGBM Network logs #2124

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

svotaw
Copy link
Collaborator

@svotaw svotaw commented Nov 4, 2023

Just some better log/excpetion handling for network issues to give more diagnostic information

Copy link

github-actions bot commented Nov 4, 2023

Hey @svotaw 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@svotaw svotaw changed the title Improve LightGBM Network logs refactor: Improve LightGBM Network logs Nov 4, 2023
@svotaw
Copy link
Collaborator Author

svotaw commented Nov 4, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #2124 (9b3bc4a) into master (a187cd0) will decrease coverage by 0.09%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
- Coverage   86.23%   86.15%   -0.09%     
==========================================
  Files         312      312              
  Lines       16466    16470       +4     
  Branches     1452     1458       +6     
==========================================
- Hits        14200    14189      -11     
- Misses       2266     2281      +15     
Files Coverage Δ
...oft/azure/synapse/ml/lightgbm/NetworkManager.scala 90.37% <25.00%> (-1.43%) ⬇️

... and 5 files with indirect coverage changes

@svotaw svotaw merged commit 5cd78c9 into microsoft:master Nov 6, 2023
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants