Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Java Class Loader When Using Link Service #2135

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Nov 15, 2023

What changes are proposed in this pull request?

Use java class loader to replace scala class loader in Synapse link service.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Manually tested on Synapse

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

Copy link

Hey @lhrotk 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@lhrotk lhrotk changed the title [WIP][Bug Fix] Use Java Class Loader When Using Link Service [WIP] fix: Use Java Class Loader When Using Link Service Nov 15, 2023
@lhrotk
Copy link
Contributor Author

lhrotk commented Nov 15, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (9b20829) 86.21% compared to head (f244c26) 85.28%.

Files Patch % Lines
...ure/synapse/ml/services/CognitiveServiceBase.scala 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
- Coverage   86.21%   85.28%   -0.93%     
==========================================
  Files         312      312              
  Lines       16477    16483       +6     
  Branches     1460     1462       +2     
==========================================
- Hits        14206    14058     -148     
- Misses       2271     2425     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is verified on Fabric then it looks good to me! Thank you Cruise!

@lhrotk lhrotk changed the title [WIP] fix: Use Java Class Loader When Using Link Service fix: Use Java Class Loader When Using Link Service Nov 17, 2023
@lhrotk
Copy link
Contributor Author

lhrotk commented Nov 20, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit f3ae146 into microsoft:master Nov 20, 2023
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants