Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guarantee one boosterPtr is allocated and freed per LightGBMBooster instance #792

Merged
merged 8 commits into from Feb 10, 2020
Merged

fix: Guarantee one boosterPtr is allocated and freed per LightGBMBooster instance #792

merged 8 commits into from Feb 10, 2020

Commits on Jan 31, 2020

  1. Move transient var to transient lazy val

    @JoanFM
    JoanFM authored and joanfontanals committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    a6d69eb View commit details
    Browse the repository at this point in the history

  2. Try guaranteeing NativeLibrary is loaded everytime it is needed but o… 

    …nly loaded once
    @JoanFM
    JoanFM committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    37da33b View commit details
    Browse the repository at this point in the history

  3. Forgot some lightGBMlibConstants

    @JoanFM
    JoanFM committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    13059a7 View commit details
    Browse the repository at this point in the history

  4. Add freeing of resources, handle all memory in BoosterHandler

    @JoanFM
    JoanFM committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    9b15b73 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Remove serialization from BoosterHandler, some documentation and mino… 

    …r changes. By boosterHandler not being serializable, it forces Serializable objects to declare it as transient
    @JoanFM
    JoanFM committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    b9b2b6e View commit details
    Browse the repository at this point in the history

  2. Style forbigs implementing finalize method, Java does not guarantee o… 

    …rder of finalization so it is dangerous. I wonder how is it guaranteed that the memory will be cleared though
    @JoanFM
    JoanFM committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    64f6ada View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2020

  1. Add finalize method to call free for Native C++ allocated memory

    @JoanFM
    JoanFM committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    41fcd47 View commit details
    Browse the repository at this point in the history

  2. predict normal correct constant

    @JoanFM
    JoanFM committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    9742891 View commit details
    Browse the repository at this point in the history