Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove save_resume/preserve_performance_counters options as it breaks… #828

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

eisber
Copy link
Contributor

@eisber eisber commented Mar 16, 2020

… SGD/BFGS chaining

@eisber
Copy link
Contributor Author

eisber commented Mar 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #828 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   85.32%   85.36%   +0.04%     
==========================================
  Files         186      186              
  Lines        8597     8597              
  Branches      507      503       -4     
==========================================
+ Hits         7335     7339       +4     
+ Misses       1262     1258       -4     
Impacted Files Coverage Δ
...a/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala 91.86% <100.00%> (+1.74%) ⬆️
.../execution/streaming/continuous/HTTPSourceV2.scala 93.04% <0.00%> (ø)
...om/microsoft/ml/spark/core/utils/ClusterUtil.scala 68.75% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd4670...9a24c71. Read the comment docs.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 038b26b into microsoft:master Mar 17, 2020
ocworld pushed a commit to AhnLab-OSS/mmlspark that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants