Move TSSMain into package samples #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSS.Java 1.0.0 packages from mvn repository cannot be used together with OSGI projects, as OSGI forbids classes without a package specified.
TSSMain.java does not specify a package and is included in the mvn package.
This leads to the compile error in OSGI projects:
The default package '.' is not permitted by the Import-Package syntax.The workaround is repackaging or unpacking and removing the TSSMain during build.
This PR just moves the TSSMain.java file into the samples package. Could you please include this PR and release?