Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xz/plugin selection #29

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Xz/plugin selection #29

merged 15 commits into from
Dec 8, 2023

Conversation

zhangxu0307
Copy link
Contributor

  1. add auto plugin selection
  2. add embedding module
  3. modify plugin registry
  4. revise some ut

@Jack-Q
Copy link
Member

Jack-Q commented Dec 7, 2023

Besides, it seems that planner, code executor are all require plugin registry to load the plugin within each session, do we have any approach to sync and notify the plugin selection in different modules?

@zhangxu0307
Copy link
Contributor Author

Besides, it seems that planner, code executor are all require plugin registry to load the plugin within each session, do we have any approach to sync and notify the plugin selection in different modules?

Following our discussion, we have decided to enable automatic plugin selection exclusively for the code generator due to the following reasons:

  1. In the case of the Planner, it necessitates complete information on all plugins for effective task planning.
  2. As for the Code Executor, loading all plugins might not cause any side effects, as the code generator is only aware of the selected plugins.

taskweaver/plugin/plugin_selection.py Outdated Show resolved Hide resolved
taskweaver/plugin/plugin_selection.py Outdated Show resolved Hide resolved
taskweaver/utils/embedding.py Outdated Show resolved Hide resolved
@3e4shi
Copy link

3e4shi commented Dec 7, 2023

4622e30

@3e4shi
Copy link

3e4shi commented Dec 7, 2023

3f796df

@Jack-Q Jack-Q merged commit 5e543b2 into main Dec 8, 2023
1 check passed
@zhangxu0307 zhangxu0307 deleted the xz/plugin_selection branch December 19, 2023 07:36
shizi1011 pushed a commit to kisejin/TaskWeaver that referenced this pull request Mar 26, 2024
1. add auto plugin selection
2. add embedding module
3. modify plugin registry
4. revise some ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants