-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review generated pages redlines and guidance as per design team requests #1229
Comments
Moving to backlog to better plan when to do this review (we don't have explicit request from design team to do a full the design review) |
we're literally doing this right now. |
We got a design review from the fluent team and will adapt the NavView and pages accordingly:
You can see design and implementation details in this PoC project. FluentDesignReview.zip To hide/customize the NavView Header depending on the selected page we use a custom NavViewHeaderBehaviour. Also updated action plan in the first comment of this issue. |
great job on the alignment! |
It is good to see there is some effort to bring more consistency to Windows apps, even in a (semi)external toolkit of controls, templates etc. It would be neat if the Fluent Design teams could make these red-lines and other specific guidance publicly available online in as much detail as Google does with its Material Design system. There are docs, and some toolkits (even if many are out of date) but they are not presented in an ideal way for those designers who are not as code and programming focused. |
@mdtauk great feedback. |
We're facing an issue in the NavViewHeaderBehaviour with CodeBehind. Possible workarounds would be:
I've attached a solution where you can see the problem and the workaround:
|
Scheme Activation Page texts are not aligned with the header |
Verified in dev-nightly: |
Action Plan:
The text was updated successfully, but these errors were encountered: