Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt+Left tooltip shows up everywhere on NavigationView #2650

Closed
touseefbsb opened this issue Oct 12, 2018 · 14 comments
Closed

Alt+Left tooltip shows up everywhere on NavigationView #2650

touseefbsb opened this issue Oct 12, 2018 · 14 comments
Assignees
Labels
Can Close Out Soon Work relating to this issue has been completed.
Milestone

Comments

@touseefbsb
Copy link

For Bugs:

When creating a project with NavigationView, the Alt + Left shortcut key to go back shows up no matter where I hover over the NavigationView ( which is basically all UI in the app ), while it actually should just show up on the actual back button only with something like Go Back (Alt + Left) also in a localized manner. I have attached a screenshot showing the tooltip appearing on hover on a random place on an empty page of NavigationView.

image

System

  • VS Version: VS 2017 15.8.7
  • WTS Wizard Version: 0.18.18284.65002
  • WTS Template Version: 0.18.18284.65002
  • Windows Build: 1809
@sibille sibille assigned sibille and mvegaca and unassigned sibille Oct 12, 2018
@crutkas
Copy link
Member

crutkas commented Oct 12, 2018

does #1229 cover this or #2488

@touseefbsb
Copy link
Author

I do not think it does.

@crutkas
Copy link
Member

crutkas commented Oct 13, 2018

For this issue, is it something we're doing or WinUI.

In nightly, just start program and hover over a nav item and the alt-left pops up.

@touseefbsb
Copy link
Author

I noticed following behviour :

When winui has 2 keyboard accelrators ( GoBack and Alt + Enter ) it shows Alt + Enter as tooltip on whole ShellPage

I commented out the Alt + Enter accelrator and now GoBack tooltip was popping up all over.

I commented out both accelrators, and now there was no tooltip, but ofcourse I lost feature of those 2 Accelerators.

@mvegaca mvegaca added the in-progress The issue is currently being actively worked on. label Oct 15, 2018
@mvegaca mvegaca added Can Close Out Soon Work relating to this issue has been completed. and removed in-progress The issue is currently being actively worked on. labels Oct 16, 2018
@mvegaca
Copy link
Collaborator

mvegaca commented Oct 16, 2018

Fixed #2679

@crutkas
Copy link
Member

crutkas commented Oct 16, 2018

Martin, is this a workaround?

@mvegaca
Copy link
Collaborator

mvegaca commented Oct 16, 2018

We've moved the Keyboard accelerators addition from Page contructor to PageLoad event.

@crutkas
Copy link
Member

crutkas commented Oct 16, 2018

So this was us, not the navview control, thanks!

Wonder why the updated navview control would act differently

@mrlacey
Copy link
Collaborator

mrlacey commented Oct 16, 2018

We've moved the Keyboard accelerators addition from Page contructor to PageLoad event.

Sounds like a possible bug in their control. Has this been escalated/reported? I can imagine other people having the same issue.

@touseefbsb
Copy link
Author

I have applied the fix in my mvvm basic app and it seems it has fixed the tooltip everywhere issue, but the thing is, now it is not showing the tooltip anywhere. I think it should show a tooltip on the backbutton. now the trick is which tooltip to show, Alt+left or go back ? or like GoBack ( Alt+Left ) ?

@sibille
Copy link
Collaborator

sibille commented Oct 17, 2018

The KeyBoardAccelerator is associated to the whole page, not only the back button. The back button should probably have it's own tooltip. I had a look and it does not seem to have a tooltip, will open an issue in NavView repo, to be sure we're setting up things correctly.

@mrlacey mrlacey added this to the 2.5 milestone Oct 23, 2018
@sibille sibille removed the Can Close Out Soon Work relating to this issue has been completed. label Oct 26, 2018
@sibille
Copy link
Collaborator

sibille commented Oct 26, 2018

Not fixed in Caliburn.Micro

@sibille sibille added the Can Close Out Soon Work relating to this issue has been completed. label Oct 29, 2018
@sibille
Copy link
Collaborator

sibille commented Nov 7, 2018

Verified on dev-nightly:
Templates version: 0.19.18311.1
Wizard version: 0.19.18310.2

@StephenLPeters
Copy link

@sibille We've received reports on the Winui repo issue that this has regressed for winui3 preview 4. microsoft/microsoft-ui-xaml#8 Do you have any thoughts on this?

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Can Close Out Soon Work relating to this issue has been completed.
Projects
None yet
Development

No branches or pull requests

6 participants