Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid headers #2707

Closed
Pinox opened this issue Oct 22, 2018 · 8 comments
Closed

Datagrid headers #2707

Pinox opened this issue Oct 22, 2018 · 8 comments
Assignees
@mvegaca
Labels
external-issue Used to indicate the issue is not directly in WTS but a third-party. Generated Code Relates specifically to code contained in the generated project. XAML issue Issue relates to the XAML in generated projects.
Milestone
Backlog

Comments

@Pinox
Copy link

Pinox commented Oct 22, 2018 •
edited

Hi,

Just something I noticed, datagrid headers are not visible when using the light theme on ts (when in focus) and there is always a tooltip that says ALT Left.

ts
@sibille
Copy link
Collaborator

sibille commented Oct 22, 2018

Thanks @Pinox, we're working on the Alt+Left (#2650). Will have a look on the datagrid headers too. Which version are you using?

@Pinox
Copy link
Author

Pinox commented Oct 22, 2018

version

@mrlacey mrlacey added this to the 2.5 milestone Oct 23, 2018
@mrlacey mrlacey added XAML issue Issue relates to the XAML in generated projects. Generated Code Relates specifically to code contained in the generated project. labels Oct 23, 2018
@sibille
Copy link
Collaborator

sibille commented Oct 29, 2018

Hi @Pinox,
to avoid showing Alt + Left we added a workaround in dev consisting in moving the KeyBoardAccelerator addition to the ShellPage's Page_Loaded event handler.

For the DataGrid issue, I think this is related to CommunityToolkit/WindowsCommunityToolkit#2373. WCT team is working on it.

@mvegaca mvegaca added the external-issue Used to indicate the issue is not directly in WTS but a third-party. label Oct 29, 2018
@sibille
Copy link
Collaborator

sibille commented Nov 13, 2018

Moving to 3.0 to revisit when fixed on community toolkit

@sibille sibille modified the milestones: 2.5, 3.0 Nov 13, 2018
@crutkas crutkas modified the milestones: 3.0, 3.1 Jan 15, 2019
@crutkas
Copy link
Member

crutkas commented Jan 15, 2019

Pushing to 3.1 / Hotfix for 3.0, should be fixed with Toolkit 5.1 which is release released Feb 13th.

@sibille sibille modified the milestones: 3.1, Backlog Feb 27, 2019
@sibille
Copy link
Collaborator

sibille commented Jan 24, 2020

After updating to Windows Community Toolkit Version 6.0.0 this looks correct now!
image

@sibille sibille closed this as completed Jan 24, 2020
@mrlacey
Copy link
Collaborator

mrlacey commented Jan 24, 2020

Do people with existing (pre-generated) apps need to do anything other than update to the latest package version?
If they do, some notes on what to do would be useful.

@sibille
Copy link
Collaborator

sibille commented Jan 24, 2020

No, we didn't do any changes to the datagrid other than updating to the latest package version.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mvegaca mvegaca

Labels
external-issue Used to indicate the issue is not directly in WTS but a third-party. Generated Code Relates specifically to code contained in the generated project. XAML issue Issue relates to the XAML in generated projects.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@mrlacey @crutkas @Pinox @mvegaca @sibille