Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using intermediate_reward causes randomly done=True #132

Closed
tshrjn opened this issue Feb 10, 2019 · 1 comment · Fixed by #135
Closed

Using intermediate_reward causes randomly done=True #132

tshrjn opened this issue Feb 10, 2019 · 1 comment · Fixed by #135

Comments

@tshrjn
Copy link

tshrjn commented Feb 10, 2019

When we switch on the intermediate_reward for the environments made via tw-custom, there's some bug which causes the env to finish the epiode(done=True) and give info["has_lost"]=True whenever the agent eats anything (for eg eat pizza). This does not happen when we're not using intermediate_reward.

Also, in the sample notebook provided, there the reward = score - self.last_score # Reward is the gain/loss in score. Is there any theory/evidence as for why this helps or is done? I'd greatly appreciate that as well.

@MarcCote
Copy link
Contributor

Hi, thanks for reporting this.

Do you still have the tw-make command line you used to generate the game along with the global seed (displayed in the terminal if you haven't used --silent), or the generated files (.ulx, .json and .ni)?

Regarding your question about reward vs score, we followed the same convention as in the DQN paper in which the reward represents the change in game score of Atari games. While it is not based on any theory/evidence, it does seem to work.

@MarcCote MarcCote mentioned this issue Feb 13, 2019
tavianator added a commit that referenced this issue Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants