Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envs/glulx: Don't assume that closed tags will have been opened in the same action #169

Merged
merged 1 commit into from
Jul 8, 2019
Merged

envs/glulx: Don't assume that closed tags will have been opened in the same action #169

merged 1 commit into from
Jul 8, 2019

Conversation

tavianator
Copy link
Contributor

This fixes #168.

@tavianator tavianator mentioned this pull request Jun 12, 2019
Closed
@MarcCote
Copy link
Contributor

Actually, we might want to detect Inform7 tags that span multiple turns :-/. For instance, issuing the restart command and answering yes, completely break the state tracking in GitGlulxML.

@MarcCote
Copy link
Contributor

MarcCote commented Jul 5, 2019

@tavianator if I remember correctly, we wanted to make a small change (i.e. only considering the ending Inform7 event tag) to this PR before merging it, right?

diguifi
diguifi previously approved these changes Jul 8, 2019
View reviewed changes
@tavianator
Copy link
Contributor Author

@MarcCote Right, done

@tavianator tavianator merged commit 3f7bc2e into master Jul 8, 2019
@tavianator tavianator deleted the to-quit-or-not-to-quit branch July 8, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcCote MarcCote MarcCote approved these changes

@diguifi diguifi diguifi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when deciding not to quit a game with tw-play
3 participants
@tavianator @MarcCote @diguifi