IDB's 'blocked' event should be an IDBVersionChangeEvent #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Thank you! LGTM. |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
|
@saschanaz should I be worried about the failing test against that commit? |
|
Yes - you should have run |
|
Uh, yes, I missed that 😬 |
saschanaz
added a commit
to saschanaz/types-web
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the spec https://w3c.github.io/IndexedDB/#ref-for-fire-a-version-change-event%E2%91%A1
From MDN https://developer.mozilla.org/en-US/docs/Web/API/IDBOpenDBRequest/blocked_event#event_type
From Chromium https://chromium.googlesource.com/chromium/blink/+/refs/heads/main/Source/modules/indexeddb/IDBOpenDBRequest.cpp#78
From Firefox https://github.com/mozilla/integration-mozilla-inbound/blob/0d01aa29ce350beca861f7d3b7b4df399b246ed0/dom/indexedDB/OpenDatabaseHelper.cpp#L1524