Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type safety of name global variable #240

Closed
wants to merge 1 commit into from
Closed

Improve type safety of name global variable #240

wants to merge 1 commit into from

Conversation

falsandtru
Copy link
Contributor

@mhegazy
Copy link
Contributor

mhegazy commented Aug 15, 2017

as noted in microsoft/TypeScript#15424 (comment), never was added for a specific reason. It is much more common for users to use the global name by mistake vs intentionally. this change was meant to alert users in these cases; unfortunately it breaks other cases, but we believe this gets the 90% case right. for other cases, window.name.

@mhegazy mhegazy closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@falsandtru @mhegazy @msftclas