Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigator.languages #263

Merged
merged 2 commits into from Jun 5, 2017
Merged

Conversation

coreh
Copy link
Contributor

@coreh coreh commented Jun 4, 2017

navigator.languages is currently not being provided along with the DOM type definitions, this PR adds it.

From the HTML 5.1 W3Cw spec:

window.navigator.languages
Returns an array of language tags representing the user’s preferred languages, with the most preferred language first. The most preferred language is the one returned by navigator.language.

https://www.w3.org/TR/2016/REC-html51-20161101/webappapis.html#language-preferences

TypeScript issue:

microsoft/TypeScript#16246

@msftclas
Copy link

msftclas commented Jun 4, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@coreh
Copy link
Contributor Author

coreh commented Jun 4, 2017

Oops, forgot to update the baseline files. Let me fix this.

@mhegazy mhegazy merged commit bc9f452 into microsoft:master Jun 5, 2017
@coreh coreh deleted the add/navigator-languages branch June 5, 2017 02:02
@coreh
Copy link
Contributor Author

coreh commented Jun 5, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants