change tests to not always pass #38
Conversation
|
Please @dmt could you explain why you're using URI other than express app instance? According to supertest documentation you can |
|
@Strnadj I didn't write those tests, I only changed the port. I guess that if |
this seems a bit crude but allows running the tests and having them take care of setting up the port to use
|
+1, I think this is a very important PR that should be merged :/ |
|
Whatever happened to this? |
test/api.test.ts
Outdated
| @@ -1,11 +1,12 @@ | |||
| import {} from 'jest'; | |||
| import {} from "jest"; | |||
There was a problem hiding this comment.
Do we need this import? Seems like it's not being used anywhere?
There was a problem hiding this comment.
I tried to change as little as possible. The quote change was just following the codestyle, IIRC.
|
hey @dmt - sorry I was away for a while.. but I'm back and going forward committed to keeping this repo fresh. I definitely want to take these changes. There are now merge conflicts from some other PRs I merged, so if you want to update this PR that'd be great. Otherwise I'll resolve them sometime this evening or tomorrow. Apologies again for the long delay! |
|
@bowdenk7 Thanks. I struggle a little remembering all the context. In particular the changes to server.ts while the contents moved to app.ts look like something I can't resolve without spending a bit more time getting back into it. So if you can resolve this, that would be appreciated. |
Added missing "node_modules/*" path mapping to README.
this seems a bit crude but allows running the tests and having them take care of setting up the port to use
change tests to not always pass
#37
As mentioned in the issue, I don't really know what I'm doing but this way I can get tests to fail if I change expectations/expected behaviour.