Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Add Azure publish support #92

Merged
merged 12 commits into from
Mar 12, 2018
Merged

Add Azure publish support #92

merged 12 commits into from
Mar 12, 2018

Conversation

bowdenk7
Copy link
Contributor

This PR is primarily for adding guidance on publishing the app. Notable changes:

  • Added new sections to the README
  • Replaced logger with Winston
  • Updated how env vars and secrets are managed

@bowdenk7
Copy link
Contributor Author

image
Pasting this here for hosting purposes...

@bowdenk7
Copy link
Contributor Author

@peterblazejewicz any chance you also want to take a look?

Copy link
Collaborator

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really enjoy seeing this site now live on the Azure!
👍

@@ -0,0 +1,16 @@
import * as winston from "winston";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The esModuleInterop: true has been added to simplify this (and help users)

import winston from "winston"`

:)

@@ -0,0 +1,26 @@
import logger from "./logger";
import * as dotenv from "dotenv";
import * as fs from "fs";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, the esModuleInterop is enabled in project to ease migration to TS :)

@bowdenk7 bowdenk7 merged commit 4d90599 into master Mar 12, 2018
brittanydrandolph pushed a commit that referenced this pull request Jun 17, 2022
Add Azure publish support
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants