Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #604 - GoTo Definition shows all function calling in file #653

Closed
wants to merge 1 commit into from
Closed

Fix issue #604 - GoTo Definition shows all function calling in file #653

wants to merge 1 commit into from

Conversation

binarynate
Copy link

This is a fix for issue #604 .

I added a 'Symbol List.tmPreferences' file to fix the issue where if you try to go to a function definition, it takes you to the first instance of where the function is used (not necessarily its definition).

I have been using this fix locally for a few weeks now, but this file was removed when I updated my TypeScript plugin.

…u try to go to a function definition, it takes you to the first instance of where the function is used (not necessarily its definition).
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 6, 2018

Hey, thanks for the PR! Can you explain where this is documented, and which declarations this is intended to cover? For example, I don't think decorators should be considered definition sites.

@stweedie
Copy link

stweedie commented Apr 10, 2018

Symbols (From sublime's documentation).

The expressions list is pulled from TypeScript.tmLanguage. the 'showInSymbolList' set to 0 means that the above expressions DO NOT appear in the symbols list. In this case, syntax equates to: don't show decorators, local variable declarations, blocks, or member variables.

The main goal is to remove some things from the symbols list. Right now, everything is shown, including local variable expressions and ALL function calls (not just the function definitions). Whichever meta elements in the .tmLanguage file you would like to ignore, place them in that list.

note that the issue referenced is 'closed' because the author received a temporary workaround and then closed that issue. In fact, every update of this plugin reverts that workaround.

@binarynate
Copy link
Author

Closing this, since I switched to VS Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants