Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set unicode escape sequences to constant.character.escape scope #783

Merged
merged 2 commits into from
Oct 28, 2019
Merged

set unicode escape sequences to constant.character.escape scope #783

merged 2 commits into from
Oct 28, 2019

Conversation

kufii
Copy link
Contributor

@kufii kufii commented Oct 25, 2019

Fixes #782

@msftclas
Copy link

msftclas commented Oct 25, 2019 •
edited

CLA assistant check
All CLA requirements met.

@kufii
Copy link
Contributor Author

kufii commented Oct 25, 2019

Also just wondering, if this PR is merged, will it affect the default JavaScript and JavaScriptReact syntaxes in VS Code? If not, is there a repo I could submit another PR to?

@sheetalkamat sheetalkamat merged commit 43ef49c into microsoft:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unicode escape sequences should have constant.character.escape scope
3 participants
@kufii @msftclas @sheetalkamat