Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add correct code examples #2700

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Docs: Add correct code examples #2700

merged 2 commits into from
Jul 24, 2023

Conversation

hiteshvijayhv
Copy link
Contributor

@hiteshvijayhv hiteshvijayhv commented Jan 30, 2023 •
edited

@hiteshvijayhv hiteshvijayhv changed the title fixes #30976: Add correct code examples Docs: Add correct code examples Jan 30, 2023
jakebailey
jakebailey requested changes May 18, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not going to try and fix this; there are big module doc updates pending which I believe will cover this.

@andrewbranch andrewbranch merged commit bf88f57 into microsoft:v2 Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch left review comments

@jakebailey jakebailey jakebailey requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs are wrong: export = and import = require(), says latter is required incorrectly
3 participants
@hiteshvijayhv @andrewbranch @jakebailey