Update LKG

microsoft · Apr 10, 2024 · 27bcd4c · 27bcd4c
1 parent 9f33bf1
commit 27bcd4c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 18 deletions.
diff --git a/lib/tsc.js b/lib/tsc.js
@@ -55344,12 +55344,10 @@ function createTypeChecker(host) {
     const target = type.target ?? type;
     const typeVariable = getHomomorphicTypeVariable(target);
     if (typeVariable && !target.declaration.nameType) {
-      const constraint = getConstraintTypeFromMappedType(type);
-      if (constraint.flags & 4194304 /* Index */) {
-        const baseConstraint = getBaseConstraintOfType(constraint.type);
-        if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
-          return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
-        }
+      const modifiersType = getModifiersTypeFromMappedType(type);
+      const baseConstraint = isGenericMappedType(modifiersType) ? getApparentTypeOfMappedType(modifiersType) : getBaseConstraintOfType(modifiersType);
+      if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
+        return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
       }
     }
     return type;

diff --git a/lib/tsserver.js b/lib/tsserver.js
@@ -60088,12 +60088,10 @@ function createTypeChecker(host) {
     const target = type.target ?? type;
     const typeVariable = getHomomorphicTypeVariable(target);
     if (typeVariable && !target.declaration.nameType) {
-      const constraint = getConstraintTypeFromMappedType(type);
-      if (constraint.flags & 4194304 /* Index */) {
-        const baseConstraint = getBaseConstraintOfType(constraint.type);
-        if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
-          return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
-        }
+      const modifiersType = getModifiersTypeFromMappedType(type);
+      const baseConstraint = isGenericMappedType(modifiersType) ? getApparentTypeOfMappedType(modifiersType) : getBaseConstraintOfType(modifiersType);
+      if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
+        return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
       }
     }
     return type;

diff --git a/lib/typescript.js b/lib/typescript.js
@@ -57843,12 +57843,10 @@ ${lanes.join("\n")}
       const target = type.target ?? type;
       const typeVariable = getHomomorphicTypeVariable(target);
       if (typeVariable && !target.declaration.nameType) {
-        const constraint = getConstraintTypeFromMappedType(type);
-        if (constraint.flags & 4194304 /* Index */) {
-          const baseConstraint = getBaseConstraintOfType(constraint.type);
-          if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
-            return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
-          }
+        const modifiersType = getModifiersTypeFromMappedType(type);
+        const baseConstraint = isGenericMappedType(modifiersType) ? getApparentTypeOfMappedType(modifiersType) : getBaseConstraintOfType(modifiersType);
+        if (baseConstraint && everyType(baseConstraint, (t) => isArrayOrTupleType(t) || isArrayOrTupleOrIntersection(t))) {
+          return instantiateType(target, prependTypeMapping(typeVariable, baseConstraint, type.mapper));
         }
       }
       return type;