Ignore allowImportingTsExtensions in transpileModule to suppress op…

…tion validation error with `noEmit` (#53599)
microsoft · Mar 31, 2023 · b29ed18 · b29ed18
1 parent 13c374a
commit b29ed18
Show file tree

Hide file tree

Showing 10 changed files with 31 additions and 0 deletions.
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -1105,6 +1105,7 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
         category: Diagnostics.Modules,
         description: Diagnostics.Allow_imports_to_include_TypeScript_file_extensions_Requires_moduleResolution_bundler_and_either_noEmit_or_emitDeclarationOnly_to_be_set,
         defaultValueDescription: false,
+        transpileOptionValue: undefined,
     },
     {
         name: "resolvePackageJsonExports",

diff --git a/src/testRunner/unittests/services/transpile.ts b/src/testRunner/unittests/services/transpile.ts
@@ -606,4 +606,18 @@ export * as alias from './file';`, {
             testVerbatimModuleSyntax: "only"
         }
     );
+
+    transpilesCorrectly("Can transpile .ts extensions without error",
+        `import { foo } from "./foo.ts";`, {
+            options: { compilerOptions: { module: ts.ModuleKind.ESNext, target: ts.ScriptTarget.ESNext } },
+            testVerbatimModuleSyntax: true
+        }
+    );
+
+    transpilesCorrectly("Ignores `allowImportingTsExtensions` without `noEmit` error",
+        `import { foo } from "./foo.ts";`, {
+            options: { compilerOptions: { module: ts.ModuleKind.ESNext, allowImportingTsExtensions: true, target: ts.ScriptTarget.ESNext } },
+            testVerbatimModuleSyntax: true
+        }
+    );
 });
diff --git a/...rence/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js b/...rence/transpile/Can transpile .ts extensions without error (verbatimModuleSyntax=true).js
diff --git a/...le/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js b/...le/Can transpile .ts extensions without error (verbatimModuleSyntax=true).oldTranspile.js
diff --git a/tests/baselines/reference/transpile/Can transpile .ts extensions without error.js b/tests/baselines/reference/transpile/Can transpile .ts extensions without error.js
diff --git a/.../baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js b/.../baselines/reference/transpile/Can transpile .ts extensions without error.oldTranspile.js
diff --git a/...le/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js b/...le/Ignores allowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).js
diff --git a/...lowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js b/...lowImportingTsExtensions without noEmit error (verbatimModuleSyntax=true).oldTranspile.js
diff --git a/.../baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js b/.../baselines/reference/transpile/Ignores allowImportingTsExtensions without noEmit error.js
diff --git a/...ference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js b/...ference/transpile/Ignores allowImportingTsExtensions without noEmit error.oldTranspile.js