Accessor declared type was not visited

microsoft · Mar 1, 2024 · c47b97d · c47b97d
1 parent 9399b32
commit c47b97d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/compiler/transformers/declarations.ts b/src/compiler/transformers/declarations.ts
@@ -871,7 +871,7 @@ export function transformDeclarations(context: TransformationContext) {
                     if (isConstTypeReference(asExpression.type) || (requiresUndefined && !canAddUndefined(type))) {
                         return undefined;
                     }
-                    else {
+                     else {
                         return visitTypeNode(type);
                     }
             }
@@ -881,7 +881,10 @@ export function transformDeclarations(context: TransformationContext) {
         function typeFromAccessor(node: AccessorDeclaration) {
             const accessorDeclarations = resolver.getAllAccessorDeclarations(node);
             const accessorType = getTypeAnnotationFromAllAccessorDeclarations(node, accessorDeclarations);
-            return accessorType ?? inferAccessorType(accessorDeclarations.getAccessor ?? node);
+            if(accessorType) {
+                return visitTypeNode(accessorType);
+            }
+            return inferAccessorType(accessorDeclarations.getAccessor ?? node);
         }
         function typeFromVariable(node: VariableDeclaration) {
             const declaredType = node.type;

diff --git a/tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.errors.txt b/tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.errors.txt
@@ -1,9 +1,12 @@
 accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS2304: Cannot find name 'DoesNotExist'.
+accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
 
 
-==== accessorDeclarationEmitVisibilityErrors.ts (1 errors) ====
+==== accessorDeclarationEmitVisibilityErrors.ts (2 errors) ====
     export class Q {
         set bet(arg: DoesNotExist) {}
                      ~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'DoesNotExist'.
+                     ~~~~~~~~~~~~
+!!! error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
     }
diff --git a/tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.js b/tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.js
@@ -9,9 +9,3 @@ export class Q {
 export class Q {
     set bet(arg) { }
 }
-
-
-//// [accessorDeclarationEmitVisibilityErrors.d.ts]
-export declare class Q {
-    set bet(arg: DoesNotExist);
-}