Don’t let other completions shadow type keywords in type locations (#…

…48939)

* Allow type keywords with the same names as other completions

* Only add type keywords that are the same as other completions in type locations

src/services/completions.ts

@@ -164,7 +164,7 @@ namespace ts.Completions {
         TypeAssertionKeywords,
         TypeKeywords,
         TypeKeyword,                    // Literally just `type`
-        Last = TypeKeywords
+        Last = TypeKeyword
     }
 
     const enum GlobalsSearch { Continue, Success, Fail }
@@ -574,7 +574,7 @@ namespace ts.Completions {
         if (keywordFilters !== KeywordCompletionFilters.None) {
             const entryNames = new Set(entries.map(e => e.name));
             for (const keywordEntry of getKeywordCompletions(keywordFilters, !insideJsDocTagTypeExpression && isSourceFileJS(sourceFile))) {
-                if (!entryNames.has(keywordEntry.name)) {
+                if (isTypeOnlyLocation && isTypeKeyword(stringToToken(keywordEntry.name)!) || !entryNames.has(keywordEntry.name)) {
                     insertSorted(entries, keywordEntry, compareCompletionEntries, /*allowDuplicates*/ true);
                 }
             }

tests/cases/fourslash/server/autoImportProvider_namespaceSameNameAsIntrinsic.ts

@@ -0,0 +1,39 @@
+/// <reference path="../fourslash.ts" />
+
+// @Filename: /node_modules/fp-ts/package.json
+//// { "name": "fp-ts", "version": "0.10.4" }
+
+// @Filename: /node_modules/fp-ts/index.d.ts
+//// export * as string from "./lib/string";
+
+// @Filename: /node_modules/fp-ts/lib/string.d.ts
+//// export declare const fromString: (s: string) => string;
+//// export type SafeString = string;
+
+// @Filename: /package.json
+//// { "dependencies": { "fp-ts": "^0.10.4" } }
+
+// @Filename: /tsconfig.json
+//// { "compilerOptions": { "module": "commonjs" } }
+
+// @Filename: /index.ts
+//// type A = { name: string/**/ }
+
+goTo.marker("");
+verify.completions({
+  marker: "",
+  includes: [{
+    name: "string",
+    sortText: completion.SortText.GlobalsOrKeywords,
+  }, {
+    name: "string",
+    sortText: completion.SortText.AutoImportSuggestions,
+    source: "fp-ts",
+    sourceDisplay: "fp-ts",
+    hasAction: true,
+  }],
+  preferences: {
+    includeCompletionsForModuleExports: true,
+    allowIncompleteCompletions: true,
+  },
+});