Prefer global over object members completions after ... (#57542)

microsoft · Feb 27, 2024 · df8d755 · df8d755
1 parent 65de938
commit df8d755
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -4322,6 +4322,7 @@ function getCompletionData(
      * @returns true if 'symbols' was successfully populated; false otherwise.
      */
     function tryGetObjectLikeCompletionSymbols(): GlobalsSearch | undefined {
+        if (contextToken?.kind === SyntaxKind.DotDotDotToken) return GlobalsSearch.Continue;
         const symbolsStartIndex = symbols.length;
         const objectLikeContainer = tryGetObjectLikeCompletionContainer(contextToken, position, sourceFile);
         if (!objectLikeContainer) return GlobalsSearch.Continue;

diff --git a/tests/cases/fourslash/completionsDotDotDotInObjectLiteral1.ts b/tests/cases/fourslash/completionsDotDotDotInObjectLiteral1.ts
@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts" />
+
+//// // https://github.com/microsoft/TypeScript/issues/57540
+////
+//// const foo = { b: 100 };
+////
+//// const bar: {
+////   a: number;
+////   b: number;
+//// } = {
+////   a: 42,
+////   .../*1*/
+//// };
+
+verify.completions({ marker: "1", includes: ["foo"], excludes: ["b"] });