Don't crash when observing invalid 'export' in object literal (#40295)

Fixes #32870
microsoft · Sep 12, 2020 · ea51fab · ea51fab
1 parent d7cd405
commit ea51fab
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/services/documentHighlights.ts b/src/services/documentHighlights.ts
@@ -204,7 +204,7 @@ namespace ts {
 
         function getNodesToSearchForModifier(declaration: Node, modifierFlag: ModifierFlags): readonly Node[] | undefined {
             // Types of node whose children might have modifiers.
-            const container = declaration.parent as ModuleBlock | SourceFile | Block | CaseClause | DefaultClause | ConstructorDeclaration | MethodDeclaration | FunctionDeclaration | ObjectTypeDeclaration;
+            const container = declaration.parent as ModuleBlock | SourceFile | Block | CaseClause | DefaultClause | ConstructorDeclaration | MethodDeclaration | FunctionDeclaration | ObjectTypeDeclaration | ObjectLiteralExpression;
             switch (container.kind) {
                 case SyntaxKind.ModuleBlock:
                 case SyntaxKind.SourceFile:
@@ -240,6 +240,11 @@ namespace ts {
                         return [...nodes, container];
                     }
                     return nodes;
+
+                // Syntactically invalid positions that the parser might produce anyway
+                case SyntaxKind.ObjectLiteralExpression:
+                    return undefined;
+
                 default:
                     Debug.assertNever(container, "Invalid container kind.");
             }

diff --git a/tests/cases/fourslash/exportInObjectLiteral.ts b/tests/cases/fourslash/exportInObjectLiteral.ts
@@ -0,0 +1,9 @@
+/// <reference path="fourslash.ts" />
+
+// @Filename: a.ts
+//// const k = {
+////     [|export|] f() { }
+//// }
+
+verify.documentHighlightsOf(test.ranges()[0], [], { filesToSearch: [test.ranges()[0].fileName] });
+