Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Brace Completion Should Not Complete < in Js Files #10763

Closed
mjbvz opened this issue Sep 7, 2016 · 1 comment
Closed

Automatic Brace Completion Should Not Complete < in Js Files #10763

mjbvz opened this issue Sep 7, 2016 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Visual Studio Integration with Visual Studio
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 7, 2016

  • TypeScript for Visual Studio 2.0.2.0 (2.0 RC)
  • VS 2015 14.0.25420.01 Update 3

This issue is coming from NTVS, which uses Typescript to power our editor: microsoft/nodejstools#1142

Repo Steps:

  1. Enable automatic brace completion for Typescript.
  2. Open blank Js file with Typescript editor.
  3. Type <

Expected behavior:
Brace completion should not close < with > in JavaScript files.

Actual behavior:
A > is inserted automatically.

From the original automatic brace completion thread ( #1484 (comment) ), I though < completion was dropped. It does not make sense in a pure js file.

@mhegazy mhegazy added the Bug A bug in TypeScript label Sep 7, 2016
@mhegazy mhegazy added this to the TypeScript 2.0.5 milestone Sep 7, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.1.2, Future Oct 27, 2016
@mjbvz mjbvz added the Visual Studio Integration with Visual Studio label Jul 17, 2018
@RyanCavanaugh
Copy link
Member

Not sure what's going on here but it seems likely it's fine by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Visual Studio Integration with Visual Studio
Projects
None yet
Development

No branches or pull requests

4 participants