-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target not optional (compiler api) #1758
Comments
Commit : 65452aa should handle the issue. |
Thanks, will that fix be released in version 1.4.2? |
no, in release 1.5, release 1.4.2 is just 1.4 in addition to critical bug fixes. |
Ok. Just patched it in gulp-typescript, it will set now the target & module by default if they are undefined, so that's working again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The compiler option interface is declared with an optional target property:
But when you provide an empty object
{}
to the compiler api, certain code won't compile. The last lines of compileNode are:The Debug.assert will fail, because undefined isn't smaller, equal nor bigger than 2 (ES6). Is this by design, or not? If this is by design, the target property should probably be marked as required.
The text was updated successfully, but these errors were encountered: