Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"locale" isn't respected in tsconfig.json #19566

Closed
DanielRosenwasser opened this issue Oct 30, 2017 · 4 comments · Fixed by SchemaStore/schemastore#362
Closed

"locale" isn't respected in tsconfig.json #19566

DanielRosenwasser opened this issue Oct 30, 2017 · 4 comments · Fixed by SchemaStore/schemastore#362
Assignees
Labels
Bug A bug in TypeScript

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 30, 2017

Create a project with a tsconfig.json, write some erroneous code, start compiling in --watch mode, and try changing the locale option around a bit. You'll see that the error messages don't actually get reflected to the currently specified language.

I thought this was a problem with tsconfig.json not getting its settings updated, but it's really just that it's not checked.

@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Oct 30, 2017
@DanielRosenwasser DanielRosenwasser changed the title Changing "locale" in tsconfig.json doesn't get reflected during --watch "locale" isn't respected in tsconfig.json Oct 30, 2017
@DanielRosenwasser DanielRosenwasser changed the title "locale" isn't respected in tsconfig.json "locale" isn't respected in tsconfig.json Oct 30, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 30, 2017

--locale is really a function of the process that is doing the compilation, either tsc or tsserver. the locale is loaded once during the process lifetime and is not changed during the execution. in that sense having it in the tsconfig.json is not right.

mhegazy added a commit to mhegazy/schemastore that referenced this issue Oct 30, 2017
@mhegazy mhegazy self-assigned this Oct 30, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 30, 2017

Pushed SchemaStore/schemastore#362 to remove --locale from tsconfig.json help.

madskristensen pushed a commit to SchemaStore/schemastore that referenced this issue Oct 30, 2017
* Fix microsoft/TypeScript#19566: Remove `--locale`

* Add `--strictFunctionTypes`
@falsandtru
Copy link
Contributor

I'm very annoyed with force applying of your localization. I don't want to see any languages without English while at coding. Localized error messages don't have compatibility with non-localized on trouble shooting.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 9, 2017

I don't want to see any languages without English while at coding

No one is forcing anything on anybody.. English is the default. I am assuming you are using VSCode, and in this case, it uses your locale for the errors. if you want to opt-out of this behavior set "typescript.locale": "en" in your settings.

//cc @mjbvz

@mhegazy mhegazy closed this as completed Nov 9, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants