Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project with composite: true fails to build if a dependency builds its .d.ts files in same directory as the .ts source files. #31181

Closed
chriseppstein opened this issue May 1, 2019 · 1 comment · Fixed by #31191
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@chriseppstein
Copy link

chriseppstein commented May 1, 2019

TypeScript Version: 3.5.0-dev.20190430

Search Terms:
composite "not in project file list"

Code
https://github.com/chriseppstein/reproduce-composite-build-issue

To reproduce:

git clone https://github.com/chriseppstein/reproduce-composite-build-issue.git
cd reproduce-composite-build-issue
yarn install
yarn compile 

Building the project succeeds with the current configuration but by changing the project to "composite": true the build will fail with an error.

This simple project consumes a published npm module with a "types" property in package.json. The format of the project is such that the build results are colocated with the source *.ts files.

Expected behavior:
The build succeeds with composite: true

Actual behavior:
The build fails with this error:

error TS6307: File '/Users/ceppstei/Projects/tmp/repro-fs-tree-diff-issue/node_modules/fs-tree-diff/lib/entry.ts' is not in project file list. Projects must list all files or use an 'include' pattern.

Related Issues:
#25636 looks similar but the fix seems to be related to the fact it was a json file.

@chriseppstein
Copy link
Author

@sheetalkamat Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
2 participants