You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would expect some slowdown from this PR since we now do more work. Specifically, when relating two types we take into account whether one is contained in an intersection and separately compute the relationship for that situation. The material-ui test case heavily uses intersection types, so the observed 1% slowdown doesn't seem entirely unreasonable.
@ahejlsberg I agree that 1% in a pathological case isn't the end of the world and I'm fine won't-fixing this - I brought it up as one more straw on the camel's back.
The extra work done in #34789 is valuable, but maybe it doesn't need to be so expensive.
Setup:
yarn
to restore packagesyarn typescript
to prebuild and run some TS testsRepro
tsc -p docs
On a random Mac Mini:
Note: to build old TS commits, you probably need to change
const { default: chalk }
toconst chalk
inscripts/build/utils.js
.The text was updated successfully, but these errors were encountered: