Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string indexers in JSX properties #4105

Closed
RyanCavanaugh opened this issue Jul 31, 2015 · 0 comments
Closed

Support string indexers in JSX properties #4105

RyanCavanaugh opened this issue Jul 31, 2015 · 0 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.6

Comments

@RyanCavanaugh
Copy link
Member

For parity with #3755, we should support string indexers in 'props' types to opt out of "closedness" for JSX properties. Requested by @codemonkeychris
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jul 31, 2015
@RyanCavanaugh RyanCavanaugh self-assigned this Jul 31, 2015
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Jul 31, 2015
@RyanCavanaugh
Implements microsoft#4105 - a string indexer in 'props' disables errors
5f96788 
due to surplus attributes
@RyanCavanaugh RyanCavanaugh mentioned this issue Jul 31, 2015
Merged
@mhegazy mhegazy added this to the TypeScript 1.6 milestone Aug 1, 2015
RyanCavanaugh added a commit that referenced this issue Aug 6, 2015
@RyanCavanaugh
Merge pull request #4106 from RyanCavanaugh/allowTsxStringIndexers
ba77592 
Implements #4105 - a string indexer in 'props' disables errors due to surplus attributes
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Aug 7, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.6
Development

No branches or pull requests
2 participants
@RyanCavanaugh @mhegazy