Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'calendar' and 'numberingSystem' should not be string literals #42885

Closed
DanielRosenwasser opened this issue Feb 19, 2021 · 0 comments · Fixed by #42886
Closed

'calendar' and 'numberingSystem' should not be string literals #42885

DanielRosenwasser opened this issue Feb 19, 2021 · 0 comments · Fixed by #42886
Assignees
@DanielRosenwasser
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.2.2

Comments

@DanielRosenwasser
Copy link
Member

@orta this should be revised/reverted. List of numbering system & calendar are NOT part of the ECMA402 spec. They conform to Unicode Locale Identifier semantic restriction, but the list can change every CLDR version which is separate from ECMA402.

Reference of failure upstream: formatjs/formatjs#2616

Originally posted by @longlho in #42134 (comment)
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Feb 19, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.2.2 milestone Feb 19, 2021
@DanielRosenwasser DanielRosenwasser self-assigned this Feb 19, 2021
@DanielRosenwasser DanielRosenwasser mentioned this issue Feb 19, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Feb 19, 2021
@peterblazejewicz peterblazejewicz mentioned this issue Mar 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.2.2
Development

Successfully merging a pull request may close this issue.

Make 'calendar' and 'numberingSystem' open strings in es2020.intl. microsoft/TypeScript
2 participants
@DanielRosenwasser @typescript-bot