-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add and enable the "Convert named imports to namespace imports" refactor action? #46034
Comments
This consistently works for me on macOS. @orta @elibarzilay or @sandersn would any of you be able to attempt a repro on Linux? |
@andrewbranch thanks for the update. I tried on my macOS box, with vscode 1.60.2 (Universal) and got this (using the little test repo linked above, just to minimize moving parts): |
Ah: I didn't remember I'd used vscode on that box before, and there were extensions hiding in But... it turns out that this refactoring doesn't help solve #46027 at all: it just switches between
and
both of which fail with the same error due to invoking the unbound method. Should I open yet another issue to solve that? |
馃槥 Yes please, thank you @mceachen |
Bug Report
馃晽 Version & Regression Information
When trying to patch up a codebase to deal with unbound named imports, I found that the "Convert named imports to namespace imports" refactor action was missing in vscode.
With 4.3:
With typescript@next:
馃捇 Code
Tested with https://github.com/mceachen/ts44-event-typeerror
馃檨 Actual behavior
The refactor action doesn't exist.
馃檪 Expected behavior
I want this: #46027 (comment)
The text was updated successfully, but these errors were encountered: