Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cmd line options to suppress warnings #6771

Closed
paulvanbrenk opened this issue Jan 31, 2016 · 4 comments
Closed

Add a cmd line options to suppress warnings #6771

paulvanbrenk opened this issue Jan 31, 2016 · 4 comments
Labels
Declined The issue was declined as something which matches the TypeScript vision Suggestion An idea for TypeScript

Comments

@paulvanbrenk
Copy link
Contributor

Instead of adding a Boolean argument for each warning we want to suppress implement a more generic method to suppress, the warnings.

e.g instead of the --noFallthroughCasesInSwitch just suppress warning 7029

@sandersn
Copy link
Member

sandersn commented Feb 1, 2016

:+!:

@mhegazy
Copy link
Contributor

mhegazy commented Feb 1, 2016

why?

@sandersn
Copy link
Member

sandersn commented Feb 1, 2016

--warn x,y,z pulls all the "even stricter" flags under a single flag. Otherwise we'll end up with a million optional strictness flags that will drown out the other flags in documentation.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 1, 2016

looking at --noFallthroughCasesInSwitch tells you what it does., but --suppressWarning 7029 is meaningless.
The other issue here is diluting the value proposition. the main value of typescript is to catch type errors. the tooling quality depends on some of these errors being addressed by the user. if we muffle some of these errors, the whole experience would degrade. On the other hand, what we provide is a set of known knobs to switch off certain groups of errors, that we have deemed as safe to ignore.
I do not think there is anything wrong with being prescriptive here. For documentation, we could split the help into main, and extended to make sure we are not drowning common flags in the --suppres* ones

@mhegazy mhegazy closed this as completed Feb 19, 2016
@mhegazy mhegazy added Suggestion An idea for TypeScript Declined The issue was declined as something which matches the TypeScript vision labels Feb 19, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Declined The issue was declined as something which matches the TypeScript vision Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants