Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on skipLibCheck for js-only inferred project and external project #11399

Merged
merged 4 commits into from Oct 12, 2016
Merged

Turn on skipLibCheck for js-only inferred project and external project #11399

merged 4 commits into from Oct 12, 2016

Conversation

zhengbli
Copy link
Contributor

@zhengbli zhengbli commented Oct 5, 2016

Fixes #8947

@zhengbli
Copy link
Contributor Author

zhengbli commented Oct 5, 2016 •
edited

The current implementation is written within the updateGraph method. The drawback of implementing this approach in updateGraph is that there are no way to override this behavior. Specifically setting skipLibCheck will not work.

The alternative approach is to run this logic in each place updateGraph is called, which might be messier code but we do know when to honor the given options and when to use the default value.

Now the behavior only exists in server, and doesn't override the compiler option. It only kicks in if no skipLibCheck was specified.

@zhengbli
Copy link
Contributor Author

Pinging @mhegazy @vladima

@zhengbli zhengbli merged commit 460de66 into microsoft:master Oct 12, 2016
@zhengbli zhengbli deleted the 8947 branch October 12, 2016 02:19
jramsay added a commit that referenced this pull request Oct 18, 2016
@jramsay
Turn on skipLibCheck for js-only inferred project and external project (
b5441de 
#11399)

* Turn on skipLibCheck for js-only inferred project and external project
* avoid changing compiler options
* Update tests
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhengbli @mhegazy @msftclas