Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix super/this capture for extends null #13277

Merged
merged 2 commits into from
Jan 5, 2017
Merged

Fix super/this capture for extends null #13277

merged 2 commits into from
Jan 5, 2017

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jan 3, 2017

Fixes #13276

@mhegazy
Copy link
Contributor

mhegazy commented Jan 3, 2017

We will need to port this to release-2.1 as well.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jan 4, 2017

I would consider an additional check, which is that if the extends clause element is syntactically null, no capture should be performed at all. Any thoughts?

@DanielRosenwasser
Copy link
Member

Also, I'd consider just making it _super && instead of _super !== null &&.

@rbuckton
Copy link
Member Author

rbuckton commented Jan 4, 2017

The spec is explicit about null. undefined should be an error/undefined behavior.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 4, 2017

@rbuckton can you merge this and port it to release-2.1 as well.

@rbuckton
Copy link
Member Author

rbuckton commented Jan 5, 2017

Sure. I was just updating it based on Daniel's suggestion above.

@rbuckton rbuckton merged commit 58ad85a into master Jan 5, 2017
rbuckton added a commit that referenced this pull request Jan 5, 2017
@rbuckton rbuckton deleted the fix13276 branch January 5, 2017 04:38
@rbuckton
Copy link
Member Author

rbuckton commented Jan 5, 2017

I've merged this into release-2.1 as well.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants