Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods for FormData type #14859

Merged
merged 2 commits into from
Mar 29, 2017
Merged

Add missing methods for FormData type #14859

merged 2 commits into from
Mar 29, 2017

Conversation

NColey
Copy link
Contributor

@NColey NColey commented Mar 26, 2017

Fixes #14813.

@msftclas
Copy link

@NColey,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@NColey, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@mhegazy
Copy link
Contributor

mhegazy commented Mar 26, 2017

Thanks for your PR. these files are not manually edited, they are auto-generatd from a script in . You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TSJS-lib-generator.

Changes should be done in https://github.com/Microsoft/TSJS-lib-generator instead.

Please find more information at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy closed this Mar 26, 2017
@mhegazy mhegazy reopened this Mar 26, 2017
@msftclas
Copy link

@NColey,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mhegazy
Copy link
Contributor

mhegazy commented Mar 26, 2017

Your changes to src/lib/DOM.iterable.d.ts we should take, please revert the other changes and send them to TSJS-lib-generator instead.

@NColey
Copy link
Contributor Author

NColey commented Mar 26, 2017

Hi @mhegazy I reverted the unnecessary changes leaving just the updates to src/lib/DOM.iterable.d.ts and moved the rest to the following PR in TSJS-lib-generator. Let me know if there is anything else I should do, thanks!

/**
* Returns an array of key, value pairs for every entry in the list
*/
entries(): IterableIterator<[string, any]>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from spec, the values are string | File; that applies to value, entries and [Symbol.iterator].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the PR with the appropriate types, thanks!

@mhegazy mhegazy merged commit 3ab7c86 into microsoft:master Mar 29, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Mar 29, 2017

thanks!

@NColey NColey deleted the form-data-methods branch March 29, 2017 15:11
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants