Ensuring local module names are unique in emit. #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…race. Also better identification of arrow function expressions.
| function getLocalNameOfContainer(container: Declaration): string { | ||
| var links = getNodeLinks(container); | ||
| if (!links.localModuleName) { | ||
| var name = container.name.text ? unescapeIdentifier(container.name.text) : "M"; |
There was a problem hiding this comment.
Comment explaining the string "M"
There was a problem hiding this comment.
The "M" is there in case the container's name is missing. It would be only if there were syntax errors and we never emit in that case, so it is purely a safety precaution.
emit 'use strict' at the beginning of the function
Binder now builds more generally useful linked list of all container declarations. Emitter uses original spelling when creating unique local container names.
Binder now builds more generally useful linked list of all container declarations. Emitter uses original spelling when creating unique local container names.
…peScript into ModuleNameConflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41 and #42.
Also fixes some errant ANSI characters that snuck into scanner.ts and checker.ts.