Improve insertion position of extracted methods #18343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old: End of target scope New: Before the first non-constructor function following the extracted range in the target scope
|
@amcasey, |
|
FYI @bterlson. |
ghost
reviewed
Sep 8, 2017
src/compiler/utilities.ts
Outdated
| @@ -505,7 +505,7 @@ namespace ts { | |||
| } | |||
| } | |||
|
|
|||
| function staticAssertNever(_: never): void {} | |||
| export function staticAssertNever(_: never): void {} | |||
There was a problem hiding this comment.
There's a duplicate function assertTypeIsNever in core.ts, or you may prefer Debug.assertNever which throws (from #18287 so you'd have to rebase this).
RyanCavanaugh
approved these changes
Sep 12, 2017
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 16, 2017
Improve insertion position of extracted methods (cherry picked from commit 40e4591)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 18, 2017
Improve insertion position of extracted methods (cherry picked from commit 40e4591)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 20, 2017
Improve insertion position of extracted methods (cherry picked from commit 40e4591)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old: End of target scope
New: Before the first non-constructor function following the extracted range in the target scope
TODO: I'm going to add more tests, but I know people are anxious for local builds of this change.