Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict function types #18654

Merged
merged 25 commits into from
Oct 2, 2017
Merged

Strict function types #18654

merged 25 commits into from
Oct 2, 2017

Commits on Sep 18, 2017

  1. Introduce --strictFunctionTypes mode

    @ahejlsberg
    ahejlsberg committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    12f5dd8 View commit details
    Browse the repository at this point in the history

  2. Use dedicated marker types for variance determination

    @ahejlsberg
    ahejlsberg committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    f8ff7f7 View commit details
    Browse the repository at this point in the history

  3. Add quick path for computing array variance as it is already known

    @ahejlsberg
    ahejlsberg committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    670d711 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. Handle contravariance in type inference

    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    a0fa69f View commit details
    Browse the repository at this point in the history

  2. Add comments

    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    b58e0fb View commit details
    Browse the repository at this point in the history

  3. Handle special case of 'void' type arguments for covariant type param… 

    …eters
    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    84f7afd View commit details
    Browse the repository at this point in the history

  4. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    54eadef View commit details
    Browse the repository at this point in the history

  5. Use methods in dom.generated.d.ts to opt out of strict checks

    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    44cc8c5 View commit details
    Browse the repository at this point in the history

  6. Update tsconfig baselines

    @ahejlsberg
    ahejlsberg committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    dd466ae View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Revert dom.generated.d.ts and fix duplicate declarations

    @ahejlsberg
    ahejlsberg committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    24698dd View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2017

  1. Properly flag and structurally compare marker type references

    @ahejlsberg
    ahejlsberg committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    f8e2cc1 View commit details
    Browse the repository at this point in the history

  2. Update comment

    @ahejlsberg
    ahejlsberg committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    589e1f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2017

  1. Always perform structural comparison when variance check fails

    @ahejlsberg
    ahejlsberg committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    afc8a26 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @ahejlsberg
    ahejlsberg committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    70e8f73 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2017

  1. Strict function type checking only for certain function types

    @ahejlsberg
    ahejlsberg committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    91691f6 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @ahejlsberg
    ahejlsberg committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    6a481e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    1795614 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Only methods and constructors are bivariant in --strictFunctionTypes … 

    …mode
    @ahejlsberg
    ahejlsberg committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    5613be4 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    1609196 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into strictFunctionTypes

    @ahejlsberg
    ahejlsberg committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    0756aa1 View commit details
    Browse the repository at this point in the history

  4. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    c626d9d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. Addressing CR feedback

    @ahejlsberg
    ahejlsberg committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    936f98d View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2017

  1. Emit .d.ts file in test

    @ahejlsberg
    ahejlsberg committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    bf75a3f View commit details
    Browse the repository at this point in the history

  2. Improve error elaboration for invariant generic types

    @ahejlsberg
    ahejlsberg committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    bff843a View commit details
    Browse the repository at this point in the history

  3. Add error elaboration test

    @ahejlsberg
    ahejlsberg committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    c2344e0 View commit details
    Browse the repository at this point in the history