Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.6 code fix cannot find module #19429

Merged
1 commit merged into from
Oct 24, 2017
Merged

Release 2.6 code fix cannot find module #19429

1 commit merged into from
Oct 24, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2017

Port of #19394

@ghost ghost changed the base branch from master to 2.1 October 23, 2017 20:38
@ghost ghost changed the base branch from 2.1 to release-2.6 October 23, 2017 20:38
@mhegazy
Copy link
Contributor

mhegazy commented Oct 23, 2017

not sure i understand why Jenkins is failing and why travis is not running..

@mhegazy
Copy link
Contributor

mhegazy commented Oct 23, 2017

looks good otherwise :)

mhegazy
mhegazy approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tests locally before submitting

@ghost
Copy link
Author

ghost commented Oct 24, 2017

Passed locally.

@ghost ghost merged commit 02cc07c into release-2.6 Oct 24, 2017
@ghost ghost deleted the release-2.6_codeFixCannotFindModule branch October 24, 2017 15:05
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mhegazy