Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional #19507

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional #19507

merged 3 commits into from
Oct 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2017

@ghost ghost force-pushed the servicesNonOptional branch from af6ae16 to b567701 Compare October 26, 2017 21:02
@ghost ghost requested a review from mhegazy October 26, 2017 21:02
@ghost
Copy link
Author

ghost commented Oct 26, 2017

@mhegazy Let's get this in for the 2.6 release.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 30, 2017

Following #19455 (comment), we should also change the API version

@mhegazy
Copy link
Contributor

mhegazy commented Oct 30, 2017

we also need that in release-2.6

@mhegazy mhegazy merged commit 277e318 into master Oct 30, 2017
@mhegazy mhegazy deleted the servicesNonOptional branch October 30, 2017 22:10
@mhegazy
Copy link
Contributor

mhegazy commented Oct 30, 2017

@andy-ms we need to port this to release-2.6 and add a note about it in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes

ghost pushed a commit that referenced this pull request Oct 30, 2017
Make getCompletionEntryDetails and getCompletionEntrySymbol parameter…
f69e74f 
…s non-optional (#19507)

* Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional

* Increment servicesVersion

* Update api baselines
@ghost ghost mentioned this pull request Oct 30, 2017
Merged
@angelozerr
Copy link

Thanks @mhegazy to have pinged me about this change. Is it possible to describe which methods change their signature at https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes (it seems that it's just for completion)

In https://github.com/angelozerr/tslint-language-service we override only getSemanticDiagnostics and getCodeFixesAtPosition, so perhaps we need to do nothing. Thanks for your feedback!

@ghost
Copy link
Author

ghost commented Oct 30, 2017

@angelozerr Added the method names. If your code compiles that should mean that you don't need to change anything.

@angelozerr
Copy link

Thanks a lot @andy-ms !

mhegazy pushed a commit that referenced this pull request Oct 31, 2017
@mhegazy
Make getCompletionEntryDetails and getCompletionEntrySymbol parameter…
0f32f55 
…s non-optional (#19507) (#19592)

* Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional

* Increment servicesVersion

* Update api baselines
@mhegazy mhegazy added Breaking Change Would introduce errors in existing code API Relates to the public API for TypeScript labels Oct 31, 2017
@mhegazy mhegazy added this to the TypeScript 2.6 milestone Oct 31, 2017
@mhegazy mhegazy mentioned this pull request Oct 31, 2017
Closed
@liyinsg liyinsg mentioned this pull request Nov 1, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
API Relates to the public API for TypeScript Breaking Change Would introduce errors in existing code
Projects
None yet
Milestone
TypeScript 2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhegazy @angelozerr