Don't offer to prepend an underscore to the name of an unused private property #20373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Nov 30, 2017
| return [functionDeclaration.parameters.length === 1 ? deleteNode(parent) : deleteNodeInList(parent), | ||
| prefixIdentifierWithUnderscore(identifier)]; | ||
| const deleteAction = functionDeclaration.parameters.length === 1 ? deleteNode(parent) : deleteNodeInList(parent); | ||
| return errorCode === Diagnostics.Property_0_is_declared_but_its_value_is_never_read.code |
There was a problem hiding this comment.
isParameterPropertyDeclaration(identifier) instead of looking at the code.
There was a problem hiding this comment.
My feeling was that the code might be applied to other symbols in the future but that it's inherently about properties so it was a valid way to perform the check.
mhegazy
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscores only help with unused parameters.