Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed property union lifting #21070

Closed
wants to merge 15 commits into from
Closed

Computed property union lifting #21070

wants to merge 15 commits into from

Commits on Jan 3, 2018

  1. Union literal computed properties lift to union 

    Still uses getSpreadType (with modifications) for combining multiple
unioned computed properties. This likely has problems that will be
exposed by more tests after I write them.
    @sandersn
    sandersn committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    3cf0bf7 View commit details
    Browse the repository at this point in the history

  2. Test literal union computed property lifting

    @sandersn
    sandersn committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    b39688c View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Print known constants in computed property types 

    Also improve some names
    @sandersn
    sandersn committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    d407c92 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2018

  1. Clean up variable naming

    @sandersn
    sandersn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    3123bef View commit details
    Browse the repository at this point in the history

  2. More computed property cases + Update baselines

    @sandersn
    sandersn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    6bec753 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Improve spread type parameter names

    @sandersn
    sandersn committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    c242f20 View commit details
    Browse the repository at this point in the history

  2. Further improve readability of checkObjectLiteral

    @sandersn
    sandersn committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    59095cd View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Print computer numeric literal property names as numeric

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    25f981f View commit details
    Browse the repository at this point in the history

  2. Improve destructuring:str/num computed properties 

    Also add declaration baselines for computedPropertyUnionLiftsToUnionType
    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    c69c4ff View commit details
    Browse the repository at this point in the history

  3. Error reporting:improve destructured computed properties

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    ddd9714 View commit details
    Browse the repository at this point in the history

  4. Computed properties with null and undefined literals

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    ea8fc7c View commit details
    Browse the repository at this point in the history

  5. Combine destructured computed property checking

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    772c75b View commit details
    Browse the repository at this point in the history

  6. Simplify parameter type 

    Let callers rely on closure instead of passing in the source type
unchanged to the lambda.
    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    85e5054 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into computed-property-union-lifting

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    a979a0d View commit details
    Browse the repository at this point in the history

  8. Fix lint:add semicolon

    @sandersn
    sandersn committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    cd3b688 View commit details
    Browse the repository at this point in the history