Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Much better comment preservation #22141

Merged
merged 20 commits into from Mar 3, 2018
Merged

Much better comment preservation #22141

merged 20 commits into from Mar 3, 2018

Commits on Feb 22, 2018

  1. Retain comments on (and produce sourcemaps on) the equals token in in… 

    …itializers
    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    f8bcc62 View commit details
    Browse the repository at this point in the history

  2. Improved comments/sourcemaps for await, yield, while, and for

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    e9bca7e View commit details
    Browse the repository at this point in the history

  3. Retain comments on block curly-braces

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    f7c3903 View commit details
    Browse the repository at this point in the history

  4. Emit comments for if statements

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    4cd74f2 View commit details
    Browse the repository at this point in the history

  5. Improved switch case comment emit

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    2a38005 View commit details
    Browse the repository at this point in the history

  6. Improve comment and sourcemap emit for try/catch, throw, and continue… 

    … statements
    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    c4c73b5 View commit details
    Browse the repository at this point in the history

  7. Improve sourcemap emit and comments for with statements

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    bf482e9 View commit details
    Browse the repository at this point in the history

  8. More accurate sourcemaps+comments emit for new, typeof, void, and delete

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    20d6f69 View commit details
    Browse the repository at this point in the history

  9. Improve comment emit for element access expressions

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    462c0b1 View commit details
    Browse the repository at this point in the history

  10. Preserve more comments on imports and exports

    @weswigham
    weswigham committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    918f184 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Make function a bit more defensive like other usages of emitTrailingC… 

    …ommentsOfPosition
    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    ec7be47 View commit details
    Browse the repository at this point in the history

  2. Support preserving comments within empty lists

    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    0d018f7 View commit details
    Browse the repository at this point in the history

  3. Handle leading comments of tokens, conditionally indent leading comments

    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    b1b1718 View commit details
    Browse the repository at this point in the history

  4. Stop heuristically sourcemapping tokens 

    When the transform was trivial it worked, but was unneeded, but when it was complex, it was brittle - best leave source mapping up to the transformers
    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    5c102a4 View commit details
    Browse the repository at this point in the history

  5. Fix unneeded +1

    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    fc0a6cc View commit details
    Browse the repository at this point in the history

  6. Tighten up element access comments

    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    89fef55 View commit details
    Browse the repository at this point in the history

  7. Handle comments on parenthesized expression tokens

    @weswigham
    weswigham committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    864f029 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Merge branch 'master' into slightly-better-comment-preservation

    @weswigham
    weswigham committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    62ccc9d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Merge branch 'master' into slightly-better-comment-preservation

    @weswigham
    weswigham committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    c4c2f9b View commit details
    Browse the repository at this point in the history

  2. Fix nit

    @weswigham
    weswigham committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    b6ebcfd View commit details
    Browse the repository at this point in the history