Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip writing json file if it is going to overwrite same location #27714

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Skip writing json file if it is going to overwrite same location #27714

merged 1 commit into from
Oct 11, 2018

Conversation

sheetalkamat
Copy link
Member

Fixes #24715

@sheetalkamat sheetalkamat merged commit 9cda8d6 into master Oct 11, 2018
@sheetalkamat sheetalkamat deleted the okToSkipJsonOverrite branch October 11, 2018 22:48
@ffMathy
Copy link

ffMathy commented Oct 15, 2018

So which version will this be out for? TS 3.2?

@jasonswearingen
Copy link

i still get this error on TS 3.3.3, when importing package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sheetalkamat @ffMathy @jasonswearingen @weswigham