Fix crash when checking function call #30758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argument, a spread argument, and overall potentially too few arguments
andrewbranch
commented
Apr 4, 2019
| tests/cases/conformance/expressions/functionCalls/callWithSpread2.ts(34,8): error TS2345: Argument of type 'number' is not assignable to parameter of type 'string'. | ||
| tests/cases/conformance/expressions/functionCalls/callWithSpread2.ts(34,8): error TS2556: Expected 1-3 arguments, but got 0 or more. | ||
| tests/cases/conformance/expressions/functionCalls/callWithSpread2.ts(35,8): error TS2345: Argument of type 'number' is not assignable to parameter of type 'string'. | ||
| tests/cases/conformance/expressions/functionCalls/callWithSpread2.ts(36,14): error TS2556: Expected 2-4 arguments, but got 1 or more. |
There was a problem hiding this comment.
These diffs because I added a line before the test cases are painful. Should I be doing something to avoid this or nah?
There was a problem hiding this comment.
That's fine I think. The errors are also shown later in the source code so its easier to see the diff that matters anyway
sheetalkamat
approved these changes
Apr 4, 2019
|
I believe this should also fix #30747 |
sandersn
approved these changes
Apr 8, 2019
RyanCavanaugh
pushed a commit
that referenced
this pull request
Apr 12, 2019
<!-- Thank you for submitting a pull request! Here's a checklist you might find useful. * [ ] There is an associated issue that is labeled 'Bug' or 'help wanted' * [ ] Code is up-to-date with the `master` branch * [ ] You've successfully run `gulp runtests` locally * [ ] There are new or updated unit tests validating the change Refer to CONTRIBUTING.MD for more details. https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md --> Fixes #30647 Upstream bugfix cherry-picked for patch release on version 3.4. See original bug for discussion: #30647 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30647
Crash occurred while getting diagnostic for a function call with
Under these circumstances, the node we were trying to put the error onto was incorrectly being calculated as an argument beyond the bounds of the arguments that actually exist.