馃 User test baselines have changed #30958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20190302
branch
from
923c381
to
8225f0b
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20190302
branch
from
8225f0b
to
ffab2b9
Compare
sandersn
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
Expected changes from @jack-williams ' elaboration of arrays/tuples.
| @@ -46,7 +46,6 @@ node_modules/adonis-framework/src/Event/index.js(256,52): error TS2345: Argument | |||
| Type 'Function' provides no match for the signature '(...values: any[]): void'. | |||
| node_modules/adonis-framework/src/Event/index.js(264,28): error TS2345: Argument of type 'Function' is not assignable to parameter of type 'Listener'. | |||
| node_modules/adonis-framework/src/Event/index.js(271,25): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type '[string, any, TimerHandler]'. | |||
| Type 'IArguments' is missing the following properties from type '[string, any, TimerHandler]': 0, 1, 2, pop, and 29 more. | |||
There was a problem hiding this comment.
less elaboration. maybe better caching?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh