Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sortText depending scope of symbols #31484

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

sheetalkamat
Copy link
Member

Fixes #15024

Sorting done as per #15024 (comment)
Sorting as per #15024 (comment) is more complicated and needs more thought so for now enabling simple sorting.

  1. Things from the lexical scope that are declared in the current file (including top-level variables in a script file)
  2. Suggested class members
  3. Things from global lexical scope and keywords
  4. Auto-import suggestions
  5. JavaScript identifiers

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked vscode issue mentioned something about a "location bonus" - is that further refining the order of zero-ranked completions on the vscode side by using brace matching and proximity?

@sheetalkamat
Copy link
Member Author

@weswigham yes

@sheetalkamat sheetalkamat merged commit 38f689d into master May 21, 2019
@sheetalkamat sheetalkamat deleted the completionsSorting branch May 21, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

favor local types and values in autocomplete popup over ambients declaration
2 participants